net: fix abort on bad address input

Backport-PR-URL: #14390
PR-URL: #13726
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: BridgeAR

lib/net.js

@@ -912,8 +912,9 @@ Socket.prototype.connect = function(options, cb) {
     this._sockname = null;
   }
 
-  var pipe = !!options.path;
-  debug('pipe', pipe, options.path);
+  const path = options.path;
+  var pipe = !!path;
+  debug('pipe', pipe, path);
 
   if (!this._handle) {
     this._handle = pipe ? new Pipe() : new TCP();
@@ -930,7 +931,10 @@ Socket.prototype.connect = function(options, cb) {
   this.writable = true;
 
   if (pipe) {
-    connect(this, options.path);
+    if (typeof path !== 'string') {
+      throw new TypeError('"path" option must be a string: ' + path);
+    }
+    connect(this, path);
   } else {
     lookupAndConnect(this, options);
   }

test/parallel/test-net-better-error-messages-path.js

@@ -2,12 +2,21 @@
 const common = require('../common');
 const net = require('net');
 const assert = require('assert');
-const fp = '/tmp/fadagagsdfgsdf';
-const c = net.connect(fp);
 
-c.on('connect', common.mustNotCall());
+{
+  const fp = '/tmp/fadagagsdfgsdf';
+  const c = net.connect(fp);
 
-c.on('error', common.mustCall(function(e) {
-  assert.strictEqual(e.code, 'ENOENT');
-  assert.strictEqual(e.message, `connect ENOENT ${fp}`);
-}));
+  c.on('connect', common.mustNotCall());
+  c.on('error', common.mustCall(function(e) {
+    assert.strictEqual(e.code, 'ENOENT');
+    assert.strictEqual(e.message, `connect ENOENT ${fp}`);
+  }));
+}
+
+{
+  assert.throws(
+    () => net.createConnection({ path: {} }),
+    /"path" option must be a string: \[object Object]/
+  );
+}