feat(git-node): auto-fetch comparison branch when preparing release#846
Merged
aduh95 merged 2 commits intonodejs:mainfrom Aug 28, 2024
Merged
feat(git-node): auto-fetch comparison branch when preparing release#846aduh95 merged 2 commits intonodejs:mainfrom
aduh95 merged 2 commits intonodejs:mainfrom
Conversation
targos
approved these changes
Aug 28, 2024
Member
targos
left a comment
There was a problem hiding this comment.
I assume you tried it locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things in the release preparation script were still relying on the local clone to be up-to-date (e.g. to get the Current line (to prepare a LTS release), it relied on the release tag to be present, or when comparing branches). Given preparing a release requires internet access anyway, it seems easy enough to rely on it rather than the local clone.
Testing it from a codespace like this: