Skip to content

[stable-3.36] Nmc/2029 Localization #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: stable-3.36
Choose a base branch
from
Open

[stable-3.36] Nmc/2029 Localization #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ android {
namespace = "com.owncloud.android"
testNamespace = "${namespace}.test"

androidResources.generateLocaleConfig = true

defaultConfig {
testInstrumentationRunnerArguments += mapOf(
"TEST_SERVER_URL" to "ncTestServerBaseUrl.toString()",
Expand Down Expand Up @@ -169,6 +167,11 @@ android {
versionName = "1"
}
}

// NMC customization to only include German and English translations and exclude the others
// By doing this no need to delete the other strings which aren't required for NMC
// Refer: https://developer.android.com/guide/topics/resources/providing-resources#AlternativeResources
resConfigs("en", "de_DE", "de")
}

applicationVariants.configureEach {
Expand Down
178 changes: 178 additions & 0 deletions app/src/androidTest/java/com/nmc/android/LocalizationResourceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,178 @@
/*
* Nextcloud - Android Client
*
* SPDX-FileCopyrightText: 2025 TSI-mc <surinder.kumar@t-systems.com>
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

package com.nmc.android

import android.content.Context
import android.content.res.Configuration
import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.owncloud.android.R
import junit.framework.TestCase.assertEquals
import org.junit.Test
import org.junit.runner.RunWith
import java.util.Locale

/**
* Test class to verify the strings customized in this branch PR for NMC
*/
@RunWith(AndroidJUnit4::class)
class LocalizationResourceTest {

private val baseContext = ApplicationProvider.getApplicationContext<Context>()

private val localizedStringMap = mapOf(
R.string.about_version to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to $$"Version %1$s",
Locale.GERMAN to $$"Version %1$s"
)
),
R.string.actionbar_see_details to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Share",
Locale.GERMAN to "Teilen"
)
),
R.string.drawer_item_on_device to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Offline files",
Locale.GERMAN to "Offline verfügbare Dateien"
)
),
R.string.prefs_lock to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Security",
Locale.GERMAN to "Sicherheit"
)
),
R.string.filedetails_download to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Offline availability",
Locale.GERMAN to "Offline Verfügbarkeit"
)
),
R.string.filedetails_sync_file to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Offline availability",
Locale.GERMAN to "Offline Verfügbarkeit"
)
),
R.string.action_send_share to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Sharing",
Locale.GERMAN to "Teilen"
)
),
R.string.common_cancel_sync to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Cancel",
Locale.GERMAN to "Abbrechen"
)
),
R.string.instant_upload_path to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "/Camera-Media",
Locale.GERMAN to "/Kamera-Medien"
)
),
R.string.prefs_synced_folders_remote_path_title to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Target folder in your MagentaCLOUD",
Locale.GERMAN to "Zielorder in Deiner MagentaCLOUD"
)
),
R.string.prefs_e2e_mnemonic to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "End-to-end encryption",
Locale.GERMAN to "Ende-zu-Ende Verschlüsselung"
)
),
R.string.storage_choose_location to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Choose Source",
Locale.GERMAN to "Wählen Sie Quelle"
)
),
R.string.subtitle_photos_videos to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Images and videos",
Locale.GERMAN to "Fotos und Videos"
)
),
R.string.show_images to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Show images",
Locale.GERMAN to "Bilder anzeigen"
)
),
R.string.subtitle_photos_only to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Images only",
Locale.GERMAN to "Nur Fotos"
)
),
R.string.select_media_folder to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Select the \"Media\" folder",
Locale.GERMAN to "Den Ordner \"Medien\" auswählen",
)
),
R.string.file_already_exists to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Filename already exists.",
Locale.GERMAN to "Dateiname bereits vorhanden",
)
),
R.string.email_pick_failed to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Failed to pick email address.",
Locale.GERMAN to "Fehler beim Zugriff auf E-Mail Adresse.",
)
),
R.string.menu_item_sort_by_date_newest_first to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Newest first",
Locale.GERMAN to "Neueste zuerst",
)
),
R.string.update_link_file_error to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "An error occurred while trying to update the share.",
Locale.GERMAN to "Fehler bei der Aktualisierungd der Freigabe aufgetreten.",
)
),
R.string.file_list_empty_unified_search_start_search_description to ExpectedLocalizedString(
translations = mapOf(
Locale.ENGLISH to "Search for files and folders",
Locale.GERMAN to "Dateien und Ordner suchen",
)
),
)

@Test
fun verifyLocalizedStrings() {
localizedStringMap.forEach { (stringRes, expected) ->
expected.translations.forEach { (locale, expectedText) ->

val config = Configuration(baseContext.resources.configuration)
config.setLocale(locale)

val localizedContext = baseContext.createConfigurationContext(config)
val actualText = localizedContext.getString(stringRes)

assertEquals(
"Mismatch for ${baseContext.resources.getResourceEntryName(stringRes)} in $locale",
expectedText,
actualText
)
}
}
}

data class ExpectedLocalizedString(val translations: Map<Locale, String>)
}
Loading