Conversation
andrewsg
added
the
do not merge
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: storage
tseaver
suggested changes
Nov 26, 2021
Contributor
|
@andrewsg The |
Contributor
Author
|
@tseaver This was on hold due to the release freeze last month. Thank you as always for your thorough review. PTAL. Will address google3 issue shortly. |
cojenco
reviewed
Jan 11, 2022
Contributor
|
So happy to see all the clean up. Nothing else to add beyond the requests that tres and cathy made; lgtm. Is there a change that should be made in here for kokoro to not try and still run the system-2.7 tests? |
Co-authored-by: cojenco <cathyo@google.com>
cojenco
reviewed
Jan 12, 2022
Contributor
cojenco
left a comment
cojenco
left a comment
There was a problem hiding this comment.
LGTM🎉🎉 Thanks Andrew for getting us across the finish line!
andrewsg
removed
the
do not merge
cojenco
approved these changes
Jan 12, 2022
tseaver
approved these changes
Jan 12, 2022
This was referenced Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This PR removes Python 2 support in the setup.py metadata, test runner and code itself. This is intended to be released as a major version update. Python 2 users can continue to use the 1.x version of the client library.