Skip to content

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Jan 21, 2026

  • feat(async_grpc_client): send user_agent to grpc channel by providing it as channel arg - "grpc.primary_user_agent".
    * This will send "user_agent" to all RPC calls.

@chandra-siri chandra-siri requested review from a team as code owners January 21, 2026 05:43
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Jan 21, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the asynchronous gRPC client for Google Cloud Storage by implementing a mechanism to consistently send a user_agent string with all gRPC API requests. This is achieved by configuring the gRPC channel with the grpc.primary_user_agent option, which is derived from either a user-provided client_info or a default value. This improvement ensures better client identification and telemetry for API interactions.

Highlights

  • User-Agent Propagation: The primary change introduces the capability to send a user_agent string to the gRPC channel, ensuring that all RPC calls made through the asynchronous gRPC client include this identifier.
  • Channel Configuration: The user_agent is now passed as a channel argument, specifically grpc.primary_user_agent, during the creation of the gRPC channel.
  • Default Client Information: If no specific client_info is provided by the user, the system will now automatically use a DEFAULT_CLIENT_INFO to construct the user_agent string.
  • Enhanced Test Coverage: New and updated unit tests have been added to validate that the user_agent is correctly configured and passed to the gRPC channel under various scenarios, including default and custom client_info.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@chandra-siri chandra-siri changed the title send user_agent to grpc channel feat(grpc_user_agent): send user_agent to grpc channel Jan 21, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements sending the user_agent to the gRPC channel by providing it as a channel argument. The changes are logical, and the accompanying tests are well-written to cover the new functionality. I have a couple of minor suggestions for code cleanup and to ensure documentation accuracy.

ankitaluthra1
ankitaluthra1 previously approved these changes Jan 21, 2026
@chandra-siri chandra-siri merged commit cdb2486 into main Jan 21, 2026
18 checks passed
@chandra-siri chandra-siri deleted the user_agent branch January 21, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants