feat: Stage 2 of nox implementation - adding docs target#473
Merged
c24t merged 6 commits intogoogleapis:masterfrom Aug 29, 2020
Merged
feat: Stage 2 of nox implementation - adding docs target#473c24t merged 6 commits intogoogleapis:masterfrom
nox implementation - adding docs target#473c24t merged 6 commits intogoogleapis:masterfrom
Conversation
Contributor
Author
|
Docs session test log: |
Contributor
Author
|
The I'd suggest to remove or at least disable this parallelization for now, as it's benefit/trouble ratio seems to be less than unity. |
Contributor
As @IlyaFaer points out in #471 (comment), we probably can't outright remove the parallelization without kokoro timing out. But hopefully we can split it into separate parallel kokoro checks. |
c24t
reviewed
Aug 28, 2020
Contributor
c24t
left a comment
There was a problem hiding this comment.
A few comments, the only substantial one is about the ../README.md line.
c24t
approved these changes
Aug 29, 2020
c24t
pushed a commit
that referenced
this pull request
Sep 15, 2020
This was referenced Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #466 , this represents the second item of the recommended list aimed to implement
noxtesting automation in multiple steps.Change list:
docstarget added to Nox configuration;readmeandchangelogfiles;.gitignore.Towards #474.