feat: add ability to set autodetect_schema query param in update_table#2171
Merged
chalmerlowe merged 6 commits intogoogleapis:mainfrom May 12, 2025
Merged
feat: add ability to set autodetect_schema query param in update_table#2171chalmerlowe merged 6 commits intogoogleapis:mainfrom
chalmerlowe merged 6 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
size: m
TheNeuralBit
changed the title
autodetectSchema query param in update_table PATCH call
chalmerlowe
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
Collaborator
|
I reviewed this. I have a PR I want to merge into this branch, but there are some failing tests so I am working through that. More to come. |
TheNeuralBit
changed the title
chalmerlowe
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
chalmerlowe
requested changes
May 12, 2025
Collaborator
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
Got a couple preferences. If you are amenable, please update.
If tests pass, we can approve.
Contributor
Author
|
Thanks @chalmerlowe I applied all your suggestions in b329cd0. Do you know why the test runs seem to be stuck? |
chalmerlowe
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
This was referenced May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2170