feat: add date, datetime, time, timestamp dtype to to_dataframe#1547
Merged
chelsea-lin merged 1 commit intomainfrom Apr 18, 2023
Merged
feat: add date, datetime, time, timestamp dtype to to_dataframe#1547chelsea-lin merged 1 commit intomainfrom
chelsea-lin merged 1 commit intomainfrom
Conversation
3075ecd to
ef363e4
Compare
tswast
requested changes
Apr 7, 2023
Contributor
tswast
left a comment
There was a problem hiding this comment.
Loving it so far.
Would you do me a favor and add a system test with "extreme" values like this one, but instead of looking for "object" dtypes, we pass in the ArrowDtype?
python-bigquery/tests/system/test_pandas.py
Line 1063 in e1aa921
5a8c0f6 to
ac07193
Compare
ac07193 to
f560802
Compare
c78c50f to
e1f7f77
Compare
36f6878 to
c9dbce3
Compare
c9dbce3 to
e321e14
Compare
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1546 🦕