Skip to content

chore: Update Dialogflow agent display name #8682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lqiu96 wants to merge 5 commits into from
Closed

chore: Update Dialogflow agent display name #8682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3266b1
chore: Log agent display name
lqiu96 Oct 25, 2022
1eaa18c
chore: Reverse the triple dot
lqiu96 Oct 25, 2022
8251fee
chore: Update default dialogflow display name
lqiu96 Oct 25, 2022
843c818
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 25, 2022
4eff6ee
removing java-dialogflow/.gitignore
suztomo Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .kokoro/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function generate_modified_modules_list() {
# Filter for java modules and get all the unique elements
# grep returns 1 (error code) and exits the pipeline if there is no match
# If there is no match, it will return true so the rest of the commands can run
modified_files=$(git diff --name-only "${KOKORO_GITHUB_PULL_REQUEST_COMMIT}...${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}")
modified_files=$(git diff --name-only "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}")
Copy link
Member Author

@lqiu96 lqiu96 Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://matthew-brett.github.io/pydagogue/git_diff_dots.html#diff-with-three-dots

I did the reverse. Should have been diffs on the PULL_REQUEST_COMMIT only

printf "Modified files:\n%s\n" "${modified_files}"

modified_module_list=()
Expand Down
6 changes: 3 additions & 3 deletions java-dialogflow/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ If you are using Maven, add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-dialogflow</artifactId>
<version>4.10.0</version>
<version>4.11.0</version>
</dependency>
```

If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-dialogflow:4.10.0'
implementation 'com.google.cloud:google-cloud-dialogflow:4.11.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-dialogflow" % "4.10.0"
libraryDependencies += "com.google.cloud" % "google-cloud-dialogflow" % "4.11.0"
```

## Authentication
Expand Down
2 changes: 1 addition & 1 deletion ...google-cloud-dialogflow/src/test/java/com/google/cloud/dialogflow/v2/it/ITSystemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public class ITSystemTest {
private static final String PROJECT_ID = ServiceOptions.getDefaultProjectId();
private static final ProjectName PROJECT_NAME = ProjectName.of(PROJECT_ID);
private static final ProjectAgentName PROJECT_AGENT_NAME = ProjectAgentName.of(PROJECT_ID);
private static final String DEFAULT_DISPLAY_NAME = "google-cloud-java-tests";
private static final String DEFAULT_DISPLAY_NAME = "google-cloud-java-tests-3b2d2e";
private static final String DISPLAY_NAME =
System.getProperty("dialogflow.agent", DEFAULT_DISPLAY_NAME);
private static final String TIME_ZONE = "America/Los_Angeles";
Expand Down