fix: add 'dict' type annotation to 'request'#966
Merged
busunkim96 merged 2 commits intomasterfrom Aug 4, 2021
Merged
Conversation
parthea
approved these changes
Aug 4, 2021
tseaver
reviewed
Aug 4, 2021
tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py
Show resolved
Hide resolved
Contributor
Worth noting that you can use it perfectly fine in earlier versions using https://github.com/python/typing/tree/master/typing_extensions |
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated libraries have always accepted both a generated type or an equivalent dict. This PR updates the type hints/docstrings to include dict.
It looks like
TypedDictcould be useful too, but we won't be able to use it until 3.8 is the lowest supported python version.