fix: tweak oneof detection#505
Merged
software-dov merged 4 commits intogoogleapis:masterfrom Jul 10, 2020
Merged
Conversation
Oneof detection and assignment to fields is tricky. This patch fixes detection of oneof fields, fixes uses in generated clients and tweaks generated tests to use them correctly.
software-dov
requested review from
arithmetic1728,
busunkim96,
crwilcox and
lukesneeringer
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Jul 9, 2020
crwilcox
approved these changes
Jul 9, 2020
busunkim96
approved these changes
Jul 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1487 1502 +15
Branches 303 308 +5
=========================================
+ Hits 1487 1502 +15
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Jul 9, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oneof detection and assignment to fields is tricky.
This patch fixes detection of oneof fields,
fixes uses in generated clients
and tweaks generated tests to use them correctly.