feat: add GOOGLE_API_USE_MTLS support#420
Merged
arithmetic1728 merged 4 commits intomasterfrom May 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1451 1451
Branches 300 300
=========================================
Hits 1451 1451 Continue to review full report at Codecov.
|
Contributor
software-dov
left a comment
There was a problem hiding this comment.
Looks good, just a few minor comments.
gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2
Show resolved
Hide resolved
software-dov
approved these changes
May 27, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the logic in go/python-apiary-mtls, section 2.2 (replaced
client_encrypted_cert_sourcewithclient_cert_sourcebecause microgenerator doesn't use encrypted client key)For the following logic, part 2 is implemented in Client constructor, part 1 is implemented in GrpcTransport constructor.