feat(snippetgen): turn resource path strings into f-strings#1012
Merged
gcf-merge-on-green[bot] merged 6 commits intomasterfrom Nov 5, 2021
Merged
feat(snippetgen): turn resource path strings into f-strings#1012gcf-merge-on-green[bot] merged 6 commits intomasterfrom
gcf-merge-on-green[bot] merged 6 commits intomasterfrom
Conversation
busunkim96
commented
Oct 7, 2021
| if not resource_message_descriptor: | ||
| resource_message = None | ||
| for service in api_schema.services.values(): | ||
| resource_message = service.resource_messages_dict.get( |
Contributor
Author
There was a problem hiding this comment.
I switched to looking through service.resource_messages_dict as the common resources (projects/{project}, folders/{folder}, ...) aren't in api_schema.messages.
parthea
approved these changes
Oct 8, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #965.
Uses the already-existing resource path logic for autogen snippets.
Previous:
Now:
Note: The logic may result in multiple variables with the same name (it doesn't happen for any of the golden APIs, but might for an API with more required fields).