Skip to content

Decrease ring buffer size to 2^31 - 1 which is wasm limit #9341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biggs0125 merged 2 commits into from
Jul 23, 2025
Merged

Decrease ring buffer size to 2^31 - 1 which is wasm limit #9341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
753d613
Decrease ring buffer size by 1.
natebiggs Jul 23, 2025
36cbbb2
Do 1 << 31 instead.
natebiggs Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...ols_app/lib/src/screens/performance/panes/timeline_events/timeline_events_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,12 @@ class TimelineEventsController extends PerformanceFeatureController
@visibleForTesting
late final Uint8ListRingBuffer traceRingBuffer;

/// Size limit in GB for [traceRingBuffer] that determines when traces should
/// be removed from the queue.
final _traceRingBufferSize = convertBytes(
1,
from: ByteUnit.gb,
to: ByteUnit.byte,
).round();
/// Size limit for [traceRingBuffer] that determines when traces should be
/// removed from the queue.
///
/// Wasm sets a size limit on byte arrays of int32 max which is specifically
/// 1 less than 1 << 31.
final _traceRingBufferSize = (1 << 31) - 1;

/// Track events that we have received from the VM, but have not yet
/// processed.
Expand Down
Loading