Skip to content

Commit 77e6e6d

Browse files
authored
Bump storage rules emulator version (#5342)
* Bump storage rules emulator version; correct null_value field accordingly * Update changelog * Format
1 parent 699c2a0 commit 77e6e6d

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@
66
- Log the reason for a Cloud Function if needed in Next.js (#5320)
77
- Fixed service enablement when installing extensions with v2 functions (#5338)
88
- Fix bug where functions:shell command didn't connect to emulators running on other processes. (#5269)
9+
- Fixed bug with Cross-Service Rules integration for Firestore documents containing nulls (#5342)

src/emulator/downloadableEmulators.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ const EMULATOR_UPDATE_DETAILS: { [s in DownloadableEmulators]: EmulatorUpdateDet
3838
expectedChecksum: "4f41d24a3c0f3b55ea22804a424cc0ee",
3939
},
4040
storage: {
41-
version: "1.1.1",
42-
expectedSize: 46448285,
43-
expectedChecksum: "691982db4019d49d345a97151bdea7e2",
41+
version: "1.1.2",
42+
expectedSize: 47028740,
43+
expectedChecksum: "983b4415b1e72b109864f1b8e7ea7546",
4444
},
4545
ui: experiments.isEnabled("emulatoruisnapshot")
4646
? { version: "SNAPSHOT", expectedSize: -1, expectedChecksum: "" }

src/emulator/storage/rules/runtime.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ function toExpressionValue(obj: any): ExpressionValue {
415415

416416
if (obj == null) {
417417
return {
418-
null_value: 0,
418+
null_value: null,
419419
};
420420
}
421421

@@ -484,7 +484,7 @@ function createRequestExpressionValue(opts: RulesetVerificationOpts): Expression
484484
},
485485
time: toExpressionValue(new Date()),
486486
resource: toExpressionValue(opts.file.after ? opts.file.after : null),
487-
auth: opts.token ? createAuthExpressionValue(opts) : { null_value: 0 },
487+
auth: opts.token ? createAuthExpressionValue(opts) : { null_value: null },
488488
};
489489

490490
return {

0 commit comments

Comments
 (0)