build: add compile-time validation of GPU buffers (#1427)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: alandtse <[email protected]>

Author: Copilot

features/Light Limit Fix/Shaders/LightLimitFix/ClusterBuildingCS.hlsl

@@ -4,10 +4,10 @@
 
 cbuffer PerFrame : register(b0)
 {
-    float LightsNear;
-    float LightsFar;
-    uint2 pad0;
-    uint4 ClusterSize;
+	float LightsNear;
+	float LightsFar;
+	uint2 pad0;  // Padding for 16-byte alignment: 8 -> 16 bytes
+	uint4 ClusterSize;
 }
 
 float3 GetPositionVS(float2 texcoord, float depth, int eyeIndex = 0)

features/Light Limit Fix/Shaders/LightLimitFix/ClusterCullingCS.hlsl

@@ -3,9 +3,9 @@
 
 cbuffer PerFrame : register(b0)
 {
-    uint LightCount;
-    uint3 pad;
-    uint4 ClusterSize;
+	uint LightCount;
+	uint3 pad0;  // Padding for 16-byte alignment: 4 -> 16 bytes
+	uint4 ClusterSize;
 }
 
 //references

src/Buffer.h

@@ -8,6 +8,9 @@
 #include <wrl\client.h>
 #include <wrl\wrappers\corewrappers.h>
 
+#define STATIC_ASSERT_ALIGNAS_16(structName) \
+	static_assert(sizeof(structName) % 16 == 0, #structName " is not a multiple of 16.");
+
 template <typename T>
 D3D11_BUFFER_DESC StructuredBufferDesc(uint64_t count, bool uav = true, bool dynamic = false)
 {

src/Deferred.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "Buffer.h"
+
 #define ALBEDO RE::RENDER_TARGETS::kINDIRECT
 #define SPECULAR RE::RENDER_TARGETS::kINDIRECT_DOWNSCALED
 #define REFLECTANCE RE::RENDER_TARGETS::kRAWINDIRECT
@@ -62,6 +64,7 @@ class Deferred
 		DirectX::XMFLOAT4X3 ShadowMapProj[2][3];
 		DirectX::XMFLOAT4X3 CameraViewProjInverse[2];
 	};
+	STATIC_ASSERT_ALIGNAS_16(PerGeometry);
 
 	ID3D11ComputeShader* copyShadowCS = nullptr;
 	Buffer* perShadow = nullptr;

src/Features/DynamicCubemaps.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "Buffer.h"
+
 class MenuOpenCloseEventHandler : public RE::BSTEventSink<RE::MenuOpenCloseEvent>
 {
 public:
@@ -21,6 +23,7 @@ struct DynamicCubemaps : Feature
 		float roughness;
 		float pad[3];
 	};
+	STATIC_ASSERT_ALIGNAS_16(SpecularMapFilterSettingsCB);
 
 	ID3D11ComputeShader* specularIrradianceCS = nullptr;
 	ConstantBuffer* spmapCB = nullptr;
@@ -36,6 +39,7 @@ struct DynamicCubemaps : Feature
 		float3 CameraPreviousPosAdjust;
 		uint pad0;
 	};
+	STATIC_ASSERT_ALIGNAS_16(UpdateCubemapCB);
 
 	ID3D11ComputeShader* updateCubemapCS = nullptr;
 	ID3D11ComputeShader* updateCubemapReflectionsCS = nullptr;

src/Features/ExtendedMaterials.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "Buffer.h"
+
 struct ExtendedMaterials : Feature
 {
 	virtual inline std::string GetName() override { return "Extended Materials"; }
@@ -36,6 +38,7 @@ struct ExtendedMaterials : Feature
 
 		float pad[1];
 	};
+	STATIC_ASSERT_ALIGNAS_16(Settings);
 
 	Settings settings;
 

src/Features/GrassCollision.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "Buffer.h"
+
 struct GrassCollision : Feature
 {
 private:
@@ -43,6 +45,7 @@ struct GrassCollision : Feature
 		uint IndexEnd = 0;
 		float2 pad0;
 	};
+	STATIC_ASSERT_ALIGNAS_16(BoundingBoxPacked);
 
 	struct alignas(16) PerFrame
 	{
@@ -56,6 +59,7 @@ struct GrassCollision : Feature
 		float CameraHeightDelta;
 		float3 pad0;
 	};
+	STATIC_ASSERT_ALIGNAS_16(PerFrame);
 
 	Settings settings;
 

src/Features/GrassLighting.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "Buffer.h"
+
 struct GrassLighting : Feature
 {
 private:
@@ -35,6 +37,7 @@ struct GrassLighting : Feature
 		float BasicGrassBrightness = 1.0f;
 		uint pad[3];
 	};
+	STATIC_ASSERT_ALIGNAS_16(Settings);
 
 	Settings settings;
 

src/Features/LightLimitFix.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "Buffer.h"
+
 struct LightLimitFix : Feature
 {
 private:
@@ -59,6 +61,7 @@ struct LightLimitFix : Feature
 		uint pad0;
 		uint pad1;
 	};
+	STATIC_ASSERT_ALIGNAS_16(LightData);
 
 	struct ClusterAABB
 	{
@@ -72,6 +75,7 @@ struct LightLimitFix : Feature
 		uint lightCount;
 		uint pad0[2];
 	};
+	STATIC_ASSERT_ALIGNAS_16(LightGrid);
 
 	struct alignas(16) LightBuildingCB
 	{
@@ -80,13 +84,15 @@ struct LightLimitFix : Feature
 		uint pad0[2];
 		uint ClusterSize[4];
 	};
+	STATIC_ASSERT_ALIGNAS_16(LightBuildingCB);
 
 	struct alignas(16) LightCullingCB
 	{
 		uint LightCount;
 		uint pad[3];
 		uint ClusterSize[4];
 	};
+	STATIC_ASSERT_ALIGNAS_16(LightCullingCB);
 
 	struct alignas(16) PerFrame
 	{
@@ -95,6 +101,7 @@ struct LightLimitFix : Feature
 		float pad0[2];
 		uint ClusterSize[4];
 	};
+	STATIC_ASSERT_ALIGNAS_16(PerFrame);
 
 	PerFrame GetCommonBufferData();
 
@@ -106,6 +113,7 @@ struct LightLimitFix : Feature
 		uint pad0;
 		LightData StrictLights[15];
 	};
+	STATIC_ASSERT_ALIGNAS_16(StrictLightDataCB);
 
 	StrictLightDataCB strictLightDataTemp;
 

src/Features/ScreenSpaceGI.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "Buffer.h"
+
 struct ScreenSpaceGI : Feature
 {
 private:
@@ -126,6 +128,7 @@ struct ScreenSpaceGI : Feature
 
 		float2 pad;
 	};
+	STATIC_ASSERT_ALIGNAS_16(SSGICB);
 	eastl::unique_ptr<ConstantBuffer> ssgiCB;
 
 	eastl::unique_ptr<Texture2D> texNoise = nullptr;