feat: add wait_for_completion method to IndexingJobs resource with sy…#49
feat: add wait_for_completion method to IndexingJobs resource with sy…#49bbatha merged 15 commits intodigitalocean:mainfrom
Conversation
bbatha
left a comment
bbatha
left a comment
There was a problem hiding this comment.
Please add dedicated error types and add tests
| poll_interval: int = 5, | ||
| timeout: int | None = None, |
There was a problem hiding this comment.
I've modified this to float.
|
@bbatha can you please review the changes and test cases and share your comments on the same? |
| except TimeoutError as e: | ||
| print(f"\n⏱️ Timeout: {e}") | ||
| except RuntimeError as e: | ||
| print(f"\n❌ Error: {e}") |
There was a problem hiding this comment.
These need to be the new types you introduced
bbatha
left a comment
bbatha
left a comment
There was a problem hiding this comment.
Very close could you just make sure the example is updated with the new exception types.
I've replaced all instances of generic execution error types with the newly created ones. |
|
@bbatha can you please take a look at the new changes? I've updated the error types in the example. |
|
There's a lint issue still @areeb1501 can you make sure to run |
|
@bbatha I've run that script. Can you please check and approve the remaining workflows? |
|
The linter appears to be picking up one last type error could you make sure that is resolved? |
|
@bbatha I have made the changes. Can you please take a look at this and approve the remaining workflows? |
|
@areeb1501 this is still failing lints |
@bbatha i've added return types for the functions in the example. This will solve the issue. |
2 participants
Fixes #41