Make Radiance model class independent #11426
Open
+181
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silveroxides
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Radiance is set up as a child class to Chroma which both is unconventional for ComfyUI codebase and a hindrance for Chroma since any updates to Chroma model class such as implementing process_img method is effectively hindered by Radiance being dependent on Chroma as parent class.
making Radiance independent not only adheres to the structure of how models are implemented in ComfyUI, but it also makes it far easier to implement and use any of the two classes in a custom node without having to worry about inheritance.