fix: Exception Handling#141
Merged
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom Mar 11, 2024
Merged
Conversation
jschell12
approved these changes
Mar 8, 2024
Member
|
GitHub isn't allowing me to comment on the line, but there's another case on line 117 we should also handle in the same way |
erezrokah
approved these changes
Mar 11, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.16](v0.1.15...v0.1.16) (2024-03-11) ### Bug Fixes * Exception Handling ([#141](#141)) ([afba5db](afba5db)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes the actual exception (rather than relying on
sys.exc_info()which can fail due to race conditions in multithreaded and async code.