fix: Call setParents on MemDB tables#217
Merged
kodiakhq[bot] merged 1 commit intomainfrom Apr 11, 2024
Merged
Conversation
erezrokah
requested review from
a team,
candiduslynx and
maaarcelino
and removed request for
a team and
maaarcelino
candiduslynx
approved these changes
Apr 11, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.27](v0.0.26...v0.0.27) (2024-04-11) ### Bug Fixes * Call setParents on `MemDB` tables ([#217](#217)) ([4015cb5](4015cb5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Apr 11, 2024
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary Same as cloudquery/plugin-sdk-java#217 This should fix the broken tables page for the Bitbucket plugin here https://hub.cloudquery.io/plugins/source/cloudquery/bitbucket/latest/tables <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](https://github.com/cloudquery/cloudquery/blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `make lint` to ensure the proposed changes follow the coding style 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Run `make test` to ensure the proposed changes pass the tests 🧪 - [ ] If changing a source plugin run `make gen` to ensure docs are up to date 📝 - [ ] Ensure the status checks below are successful ✅ --->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the table list for Bitbucket plugin is broken in the Hub. The reason is that we don't call
setParentsthus publish all tables as top level ones. The UI then tries to render items with duplicate keys and fails.This PR fixes the MemDB plugin in the SDK which is used as a reference for other plugins. I'll fix the Bitbucket plugin in a separate PR.
There might be a better way to implicitly initialize the parents but I don't think we should spend more time on it