Skip to content

fix: Parquet premature closing#652

Merged
disq merged 2 commits intomainfrom
fix/parquet-premature-close
Jul 1, 2025
Merged

fix: Parquet premature closing#652
disq merged 2 commits intomainfrom
fix/parquet-premature-close

Conversation

@disq
Copy link
Member

@disq disq commented Jul 1, 2025

Make sure ParquetWriter doesn't close our io.Writer: WriteFooter() shouldn't close the file.

https://github.com/apache/arrow-go/blob/v18.3.1/parquet/internal/utils/write_utils.go#L46

@github-actions github-actions bot added fix and removed fix labels Jul 1, 2025
@disq disq requested a review from murarustefaan July 1, 2025 18:11
@erezrokah
Copy link
Member

Fixes https://github.com/cloudquery/cloudquery-issues/issues/1824 and cloudquery/cloudquery#17549

@disq disq merged commit 5a9dfc3 into main Jul 1, 2025
8 checks passed
@disq disq deleted the fix/parquet-premature-close branch July 1, 2025 18:29
kodiakhq bot pushed a commit that referenced this pull request Jul 1, 2025
🤖 I have created a release *beep* *boop*
---


## [4.6.5](v4.6.4...v4.6.5) (2025-07-01)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/codegen to v0.3.29 ([#642](#642)) ([0139219](0139219))
* Parquet premature closing ([#652](#652)) ([5a9dfc3](5a9dfc3))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants