chore: improve dev workflow #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/upgrade
branch
from
663236f to
63117ec
Compare
satya164
force-pushed
the
@satya164/upgrade
branch
5 times, most recently
from
14c395f to
672c2f4
Compare
satya164
force-pushed
the
@satya164/upgrade
branch
from
9502670 to
6a81813
Compare
satya164
force-pushed
the
@satya164/upgrade
branch
from
6a81813 to
5343b13
Compare
satya164
force-pushed
the
@satya164/upgrade
branch
from
4760ebb to
102c151
Compare
| @@ -0,0 +1,31 @@ | |||
| /* eslint-disable import/no-commonjs */ | |||
Contributor
There was a problem hiding this comment.
@satya164 is this for watching changes in the library instead of manually copying?
| "prop-types": "^15.5.10", | ||
| "react-native-drawer": "^2.3.0" | ||
| }, | ||
| "scripts": { |
Contributor
There was a problem hiding this comment.
@satya164 Just curious why did you move scripts to the bottom?
Member
Author
There was a problem hiding this comment.
just easier to find at bottom
example/rn-cli.config.js
Outdated
| /* eslint-disable prettier/prettier */ | ||
| return blacklist([ | ||
| new RegExp( | ||
| `^${escape(path.resolve(__dirname, '..', 'node_modules'))}\\/.*$`, |
Contributor
There was a problem hiding this comment.
The trailing comma crashes the packager for me
example/rn-cli.config.js
Outdated
| `^${escape(path.resolve(__dirname, '..', 'node_modules'))}\\/.*$`, | ||
| ), | ||
| new RegExp( | ||
| `^${escape(path.resolve(__dirname, '..', 'docs', 'node_modules'))}\\/.*$`, |
Contributor
|
@satya164 Other than the trailing comma issue in |
Member
Author
|
Damn, the |
ahmedlhanafy
approved these changes
May 17, 2017
This was referenced May 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #101 and #102.