Skip to content

Commit e24b445

Browse files
Remove useless lines in tracked-controls component (#5770)
* Remove useless lines in tracked-controls component, those should have been removed when tracked-controls-webxr was renamed to tracked-controls in 627698d * Rename tracked-controls-webxr to tracked-controls in the warning message
1 parent 147adb2 commit e24b445

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/components/hand-tracking-controls.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ export var Component = registerComponent('hand-tracking-controls', {
149149
xrSession.requestReferenceSpace(referenceSpaceType).then(function (referenceSpace) {
150150
self.referenceSpace = referenceSpace;
151151
}).catch(function (error) {
152-
self.el.sceneEl.systems.webxr.warnIfFeatureNotRequested(referenceSpaceType, 'tracked-controls-webxr uses reference space ' + referenceSpaceType);
152+
self.el.sceneEl.systems.webxr.warnIfFeatureNotRequested(referenceSpaceType, 'tracked-controls uses reference space ' + referenceSpaceType);
153153
throw error;
154154
});
155155
},

src/components/tracked-controls.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ export var Component = registerComponent('tracked-controls', {
3636

3737
init: function () {
3838
this.buttonEventDetails = {};
39-
this.buttonStates = this.el.components['tracked-controls'].buttonStates = {};
40-
this.axis = this.el.components['tracked-controls'].axis = [0, 0, 0];
39+
this.buttonStates = {};
40+
this.axis = [0, 0, 0];
4141
this.changedAxes = [];
4242
this.axisMoveEventDetail = {axis: this.axis, changed: this.changedAxes};
4343

@@ -80,8 +80,6 @@ export var Component = registerComponent('tracked-controls', {
8080
this.data.iterateControllerProfiles,
8181
this.data.handTrackingEnabled
8282
);
83-
// Legacy handle to the controller for old components.
84-
this.el.components['tracked-controls'].controller = this.controller;
8583
},
8684

8785
tick: function () {

0 commit comments

Comments
 (0)