Skip to content

Commit 771de93

Browse files
richard-townsend-armTrott
authored andcommitted
build: zlib build error on Windows on Arm
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent c1bea99 commit 771de93

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tools/v8_gypfiles/v8.gyp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1629,7 +1629,13 @@
16291629
'toolsets': ['host', 'target'],
16301630
}],
16311631
['OS=="win"', {
1632-
'defines': ['X86_WINDOWS'],
1632+
'conditions': [
1633+
['"<(target_arch)"=="arm64" and _toolset=="target"', {
1634+
'defines': ['CPU_NO_SIMD']
1635+
}, {
1636+
'defines': ['X86_WINDOWS']
1637+
}]
1638+
]
16331639
}],
16341640
],
16351641
'direct_dependent_settings': {

0 commit comments

Comments
 (0)