add test for as.data.table.data.frame(x, keep.rownames=TRUE)#6884
Merged
MichaelChirico merged 1 commit intomasterfrom Mar 25, 2025
Merged
add test for as.data.table.data.frame(x, keep.rownames=TRUE)#6884MichaelChirico merged 1 commit intomasterfrom
as.data.table.data.frame(x, keep.rownames=TRUE)#6884MichaelChirico merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6884 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 79 79
Lines 14665 14665
=======================================
Hits 14459 14459
Misses 206 206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelChirico
approved these changes
Mar 25, 2025
Member
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
LGTM, please add it to https://github.com/Rdatatable/data.table/tree/patch-1.17.2
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #6865