Skip to content

Fix: Uploading artifacts to Gradle Plugin Portal and Maven Central #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rolf-Smit merged 1 commit into from
Sep 4, 2024
Merged

Fix: Uploading artifacts to Gradle Plugin Portal and Maven Central #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
3 changes: 2 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
15 changes: 10 additions & 5 deletions gradlew
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 13 additions & 8 deletions plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import com.vanniktech.maven.publish.GradlePlugin
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.SonatypeHost

plugins {
Expand Down Expand Up @@ -39,12 +37,6 @@ jacocoTestReport {
}

mavenPublishing {
// Override default configuration: by default `com.vanniktech.maven.publish` uses
// `new GradlePublishPlugin()` because it detects that we use `com.gradle.plugin-publish`.
// However since we also publish to Maven Central the default publication created by
// `com.gradle.plugin-publish` is not suitable (Maven Central publication requires sources
// and Javadoc).
configure(new GradlePlugin(new JavadocJar.Dokka("dokkaHtml")))
publishToMavenCentral(SonatypeHost.S01)
signAllPublications()
}
Expand All @@ -63,6 +55,19 @@ gradlePlugin {
}
}

// Since version 1.0.0 com.gradle.plugin-publish creates it's own javadocs, these do not
// seem to support Kotlin and end-up empty. The plugin does not provide an easy way to
// use Dokka or modify it.
// The code below disables the default javadoc task, and modifies the javadocJar task to use dokka
// instead.
tasks.named('javadoc') {
enabled = false
}
tasks.register('javadocJar', Jar) {
archiveClassifier.set('javadoc')
dependsOn tasks.dokkaHtml
from tasks.dokkaHtml
}
test {
testLogging {
events "passed", "skipped", "failed"
Expand Down