Skip to content

Check for devices before building the project #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teobugslayer merged 1 commit into from
Nov 16, 2015
Merged

Check for devices before building the project #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/services/init-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export class InitService implements IInitService {
private _projectFilePath: string;

constructor(private $fs: IFileSystem,
private $errors: IErrors,
private $logger: ILogger,
private $options: IOptions,
private $injector: IInjector,
Expand Down
6 changes: 5 additions & 1 deletion lib/services/platform-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ export class PlatformService implements IPlatformService {
this.ensurePlatformInstalled(platform).wait();
let platformData = this.$platformsData.getPlatformData(platform);

this.$devicesService.initialize({platform: platform, deviceId: this.$options.device}).wait();
if (this.$devicesService.deviceCount < 1) {
this.$errors.failWithoutHelp("Cannot find connected devices. Reconnect any connected devices, verify that your system recognizes them, and run this command again.");
}

let cachedDeviceOption = this.$options.forDevice;
this.$options.forDevice = true;
this.buildPlatform(platform, buildConfig).wait();
Expand All @@ -344,7 +349,6 @@ export class PlatformService implements IPlatformService {
let packageFile = this.getLatestApplicationPackageForDevice(platformData).wait().packageName;
this.$logger.out("Using ", packageFile);

this.$devicesService.initialize({platform: platform, deviceId: this.$options.device}).wait();
let action = (device: Mobile.IDevice): IFuture<void> => {
return (() => {
platformData.platformProjectService.deploy(device.deviceInfo.identifier).wait();
Expand Down