Support contributing different keybindings based on keyboard layout

[weinand]

VSCode should ship out of the box with multiple keymaps (based on/optimized for each keyboard layout).
e.g. toggle line comment should be ctrl+7 on swiss keyboards, etc.

VSCode should detect at runtime the current system keyboard layout and employ different defaults, based on the keyboard layout.

[bpasero]

Hm it should be...

[bpasero]

So Cmd++ works for me, which is cool. However what is weird is that we set the keybinding like this:

{ primary: KeyMod.CtrlCmd | KeyCode.US_EQUAL }

I could not find KeyCode.US_PLUS.

@alexandrudima can you comment on this maybe?

[weinand]

@bpasero does Cmd++ work for you on a non-US keyboard?

[bpasero]

@weinand yes I am on german keyboard layout (ibm) and interestingly when I type "Cmd++" into the keyboard widget, I see it prints Cmd+= for me. What does it print for you?

[weinand]

@bpasero I'm on a Swiss German keyboard and I see "shift+cmd+=" and I know where the '=' comes from. On a US keyboard the '+' and the '=' are together on a key and since we only have KeyCode constants for the unshifted key, it is KeyCode.US_EQUAL.

@bpasero restating my question from above: did Cmd++ work for you without changing the keybinding?