Solid Particle Implementation for E-L Solver#1301
Draft
JA0307 wants to merge 4 commits intoMFlowCode:masterfrom
Draft
Solid Particle Implementation for E-L Solver#1301JA0307 wants to merge 4 commits intoMFlowCode:masterfrom
JA0307 wants to merge 4 commits intoMFlowCode:masterfrom
Conversation
added 4 commits
March 11, 2026 19:23
This adds checks for particles_lagrange wherever "bubbles_lagrange is checked Variables for lagrangian solid particles are implemented
This adds two files to MFC. This includes src/simulation/m_particles_EL.fpp and src/simulation/m_particles_EL_kernels.fpp, which are used to compute particle dynamics, collisions, source terms, drag, integrate particle positions, etc.
…ication This implements mpi communication of collision forces with ghost particles in simulation/m_mpi_proxy.fpp The particle transfer between mpi ranks is made to support a "ghost" region and only the physical mpi domain. The ghost transfer is done when collisions are being computed. The physical transfer is done for true particle ownership.
This commit adds files necessary for compiling and running the EL particle solver. These files/changes are not part of this specific feature development. These changes are part of the MovingBubblesFresh commits. Since this feature for moving solid lagrangian particles is a fork of the MovingBubblesFresh development fork, it has inherent dependencies. When MovingBubblesFresh gets merged into MFC, this commit will be irrelevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update expands upon the pre-existing (in development) E-L solver for bubble dynamics to include solid particle dynamics. This is in support of the PSAAP center, which requires the capability to model solid particle dynamics in MFC.
Type of change
Testing
The solver has been tested by running various 2D/3D problems involving fluid-particle interactions, such as spherical blasts surrounded by a layer of particles, shock-particle curtains, collision tests, etc.
The inputs to the EL solid particle solver have all been turned on/off to verify they work independent of each other, and together.
The code has been tested for CPU and GPU usage. The GPU usage has been tested on Tuolumne.
Two new files have been added:
m_particles_EL.fpp
m_particles_EL_kernels.fpp
File 1 has the main particle dynamics subroutines. This initializes the particles, computes fluid forces, coupling terms, computes collision forces, enforces boundary conditions, and writes the data for post-processing.
File 2 has the gaussian kernel projection code and the subroutine to compute the force on the particle due to the fluid. This compute the quasi-steady drag force, pressure gradient force, added mass force, stokes drag, gravitational force. Models for the quasi-steady drag are implemented here.
Checklist
See the developer guide for full coding standards.
GPU changes (expand if you modified
src/simulation/)AI code reviews
Reviews are not triggered automatically. To request a review, comment on the PR:
@coderabbitai review— incremental review (new changes only)@coderabbitai full review— full review from scratch/review— Qodo review/improve— Qodo code suggestions