[MOB-11827] add-new-architecture-support #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

lposen merged 21 commits into new-arch/master from new-arch/MOB-11827-add-new-architecture-support

Aug 21, 2025

Iterable-React-Native-SDK.podspec

-Original file line number
+Diff line change
@@ -1,7 +1,6 @@
     require "json"
     package = JSON.parse(File.read(File.join(__dir__, "package.json")))
-    folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'
     Pod::Spec.new do |s|
       s.name         = "Iterable-React-Native-SDK"
@@ Expand All / @@ -14,31 +13,20 @@ Pod::Spec.new do |s| @@
       s.platforms    = { :ios => min_ios_version_supported }
       s.source       = { :git => "https://github.com/Iterable/react-native-sdk.git", :tag => "#{s.version}" }
-      s.source_files = "ios/**/*.{h,m,mm,swift}"
-      # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
-      # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
-      if respond_to?(:install_modules_dependencies, true)
-        install_modules_dependencies(s)
-      else
-        s.dependency "React-Core"
-        # Don't install the dependencies when we run `pod install` in the old architecture.
-        if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
-          s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
-          s.pod_target_xcconfig    = {
-              "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
-              "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
-              "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
-          }
-          s.dependency "React-Codegen"
-          s.dependency "RCT-Folly"
-          s.dependency "RCTRequired"
-          s.dependency "RCTTypeSafety"
-          s.dependency "ReactCommon/turbomodule/core"
-        end
-      end
+      s.source_files = "ios/**/*.{h,m,mm,cpp,swift}"
+      s.private_header_files = "ios/**/*.h"
+      # Load Iterables iOS SDK as a dependency
       s.dependency "Iterable-iOS-SDK", "6.5.4"
+      # Basic Swift support
+      s.pod_target_xcconfig = {
+        'DEFINES_MODULE'      => 'YES',
+        'CLANG_ENABLE_MODULES' => 'YES',
+        'SWIFT_VERSION'       => '5.0',
+        "CLANG_CXX_LANGUAGE_STANDARD" => rct_cxx_language_standard(),
+      }
+      install_modules_dependencies(s)
     end

example/ios/Podfile

-Original file line number
+Diff line change
@@ Expand Up / @@ -13,7 +13,9 @@ prepare_react_native_project! @@
     linkage = ENV['USE_FRAMEWORKS']
     if linkage != nil
       Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
-      use_frameworks! :linkage => linkage.to_sym
+      # IMPORTANT: New Architecture Issue solution
+      # This is needed to use the Swift code from Iterable-iOS-SDK in the RNIterableAPI module
+      use_frameworks! :linkage => :dynamic
     end
     target 'ReactNativeSdkExample' do
@@ Expand Down @@

example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -10,9 +10,9 @@
  
    		00E356F31AD99517003FC87E /* ReactNativeSdkExampleTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 00E356F21AD99517003FC87E /* ReactNativeSdkExampleTests.m */; };

    		13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; };

    		779227342DFA3FB500D69EC0 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 779227332DFA3FB500D69EC0 /* AppDelegate.swift */; };

    		77F63EC390061314C0718D51 /* libPods-ReactNativeSdkExample.a in Frameworks */ = {isa = PBXBuildFile; fileRef = F395BEFC7809290D1773C84F /* libPods-ReactNativeSdkExample.a */; };

    		81AB9BB82411601600AC10FF /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */; };

    		A3A40C20801B8F02005FA4C0 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = 1FC6B09E65A7BD9F6864C5D8 /* PrivacyInfo.xcprivacy */; };

    		D8AD8DD7C4BBDAA8AE397A1B /* libPods-ReactNativeSdkExample.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 1BA21919EC27D7F5BAE79A81 /* libPods-ReactNativeSdkExample.a */; };

    /* End PBXBuildFile section */

    /* Begin PBXContainerItemProxy section */

    @@ -33,15 +33,15 @@
  
    		13B07FB51A68108700A75B9A /* Images.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; name = Images.xcassets; path = ReactNativeSdkExample/Images.xcassets; sourceTree = "<group>"; };

    		13B07FB61A68108700A75B9A /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = Info.plist; path = ReactNativeSdkExample/Info.plist; sourceTree = "<group>"; };

    		13B07FB81A68108700A75B9A /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = PrivacyInfo.xcprivacy; path = ReactNativeSdkExample/PrivacyInfo.xcprivacy; sourceTree = "<group>"; };

    		1BA21919EC27D7F5BAE79A81 /* libPods-ReactNativeSdkExample.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-ReactNativeSdkExample.a"; sourceTree = BUILT_PRODUCTS_DIR; };

    		1FC6B09E65A7BD9F6864C5D8 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xml; name = PrivacyInfo.xcprivacy; path = ReactNativeSdkExample/PrivacyInfo.xcprivacy; sourceTree = "<group>"; };

    		24F802EFDCFB094D34916C72 /* Pods-ReactNativeSdkExample.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ReactNativeSdkExample.release.xcconfig"; path = "Target Support Files/Pods-ReactNativeSdkExample/Pods-ReactNativeSdkExample.release.xcconfig"; sourceTree = "<group>"; };

    		627A5082522E8122626A42E9 /* Pods-ReactNativeSdkExample.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ReactNativeSdkExample.debug.xcconfig"; path = "Target Support Files/Pods-ReactNativeSdkExample/Pods-ReactNativeSdkExample.debug.xcconfig"; sourceTree = "<group>"; };

    		779227312DFA3FB500D69EC0 /* ReactNativeSdkExample-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "ReactNativeSdkExample-Bridging-Header.h"; sourceTree = "<group>"; };

    		779227322DFA3FB500D69EC0 /* ReactNativeSdkExampleTests-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "ReactNativeSdkExampleTests-Bridging-Header.h"; sourceTree = "<group>"; };

    		779227332DFA3FB500D69EC0 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = AppDelegate.swift; path = ReactNativeSdkExample/AppDelegate.swift; sourceTree = "<group>"; };

    		81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = LaunchScreen.storyboard; path = ReactNativeSdkExample/LaunchScreen.storyboard; sourceTree = "<group>"; };

    		C37A515B34C484F156F48110 /* Pods-ReactNativeSdkExample.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ReactNativeSdkExample.release.xcconfig"; path = "Target Support Files/Pods-ReactNativeSdkExample/Pods-ReactNativeSdkExample.release.xcconfig"; sourceTree = "<group>"; };

    		ED297162215061F000B7C4FE /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; };

    		EDCEA27594161CE66029771A /* Pods-ReactNativeSdkExample.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ReactNativeSdkExample.debug.xcconfig"; path = "Target Support Files/Pods-ReactNativeSdkExample/Pods-ReactNativeSdkExample.debug.xcconfig"; sourceTree = "<group>"; };

    		F395BEFC7809290D1773C84F /* libPods-ReactNativeSdkExample.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-ReactNativeSdkExample.a"; sourceTree = BUILT_PRODUCTS_DIR; };

    /* End PBXFileReference section */

    /* Begin PBXFrameworksBuildPhase section */

    @@ -56,7 +56,7 @@
  
    			isa = PBXFrameworksBuildPhase;

    			buildActionMask = 2147483647;

    			files = (

    				D8AD8DD7C4BBDAA8AE397A1B /* libPods-ReactNativeSdkExample.a in Frameworks */,

    				77F63EC390061314C0718D51 /* libPods-ReactNativeSdkExample.a in Frameworks */,

    			);

    			runOnlyForDeploymentPostprocessing = 0;

    		};

    @@ -99,7 +99,7 @@
  
    			isa = PBXGroup;

    			children = (

    				ED297162215061F000B7C4FE /* JavaScriptCore.framework */,

    				1BA21919EC27D7F5BAE79A81 /* libPods-ReactNativeSdkExample.a */,

    				F395BEFC7809290D1773C84F /* libPods-ReactNativeSdkExample.a */,

    			);

    			name = Frameworks;

    			sourceTree = "<group>";

    @@ -138,8 +138,8 @@
  
    		BBD78D7AC51CEA395F1C20DB /* Pods */ = {

    			isa = PBXGroup;

    			children = (

    				EDCEA27594161CE66029771A /* Pods-ReactNativeSdkExample.debug.xcconfig */,

    				24F802EFDCFB094D34916C72 /* Pods-ReactNativeSdkExample.release.xcconfig */,

    				627A5082522E8122626A42E9 /* Pods-ReactNativeSdkExample.debug.xcconfig */,

    				C37A515B34C484F156F48110 /* Pods-ReactNativeSdkExample.release.xcconfig */,

    			);

    			path = Pods;

    			sourceTree = "<group>";

    @@ -169,13 +169,13 @@
  
    			isa = PBXNativeTarget;

    			buildConfigurationList = 13B07F931A680F5B00A75B9A /* Build configuration list for PBXNativeTarget "ReactNativeSdkExample" */;

    			buildPhases = (

    				F706883CA13F4E50A06B85B2 /* [CP] Check Pods Manifest.lock */,

    				00A09C8D745F4A4962CFCB16 /* [CP] Check Pods Manifest.lock */,

    				13B07F871A680F5B00A75B9A /* Sources */,

    				13B07F8C1A680F5B00A75B9A /* Frameworks */,

    				13B07F8E1A680F5B00A75B9A /* Resources */,

    				00DD1BFF1BD5951E006B06BC /* Bundle React Native code and images */,

    				2128D4591E26BD193F1293F1 /* [CP] Embed Pods Frameworks */,

    				BBD6908F2EAA6D3A6C078EA9 /* [CP] Copy Pods Resources */,

    				70E3A2A47E764F7A78602595 /* [CP] Embed Pods Frameworks */,

    				EDF40E5EF2B0A60C77B1B71B /* [CP] Copy Pods Resources */,

    			);

    			buildRules = (

    			);

    @@ -244,6 +244,28 @@
  
    /* End PBXResourcesBuildPhase section */

    /* Begin PBXShellScriptBuildPhase section */

    		00A09C8D745F4A4962CFCB16 /* [CP] Check Pods Manifest.lock */ = {

    			isa = PBXShellScriptBuildPhase;

    			buildActionMask = 2147483647;

    			files = (

    			);

    			inputFileListPaths = (

    			);

    			inputPaths = (

    				"${PODS_PODFILE_DIR_PATH}/Podfile.lock",

    				"${PODS_ROOT}/Manifest.lock",

    			);

    			name = "[CP] Check Pods Manifest.lock";

    			outputFileListPaths = (

    			);

    			outputPaths = (

    				"$(DERIVED_FILE_DIR)/Pods-ReactNativeSdkExample-checkManifestLockResult.txt",

    			);

    			runOnlyForDeploymentPostprocessing = 0;

    			shellPath = /bin/sh;

    			shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n    # print error to STDERR\n    echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n    exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";

    			showEnvVarsInLog = 0;

    		};

    		00DD1BFF1BD5951E006B06BC /* Bundle React Native code and images */ = {

    			isa = PBXShellScriptBuildPhase;

    			buildActionMask = 2147483647;

    @@ -260,7 +282,7 @@
  
    			shellPath = /bin/sh;

    			shellScript = "set -e\n\nWITH_ENVIRONMENT=\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n";

    		};

    		2128D4591E26BD193F1293F1 /* [CP] Embed Pods Frameworks */ = {

    		70E3A2A47E764F7A78602595 /* [CP] Embed Pods Frameworks */ = {

    			isa = PBXShellScriptBuildPhase;

    			buildActionMask = 2147483647;

    			files = (

    @@ -277,7 +299,7 @@
  
    			shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-ReactNativeSdkExample/Pods-ReactNativeSdkExample-frameworks.sh\"\n";

    			showEnvVarsInLog = 0;

    		};

    		BBD6908F2EAA6D3A6C078EA9 /* [CP] Copy Pods Resources */ = {

    		EDF40E5EF2B0A60C77B1B71B /* [CP] Copy Pods Resources */ = {

    			isa = PBXShellScriptBuildPhase;

    			buildActionMask = 2147483647;

    			files = (

    @@ -294,28 +316,6 @@
  
    			shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-ReactNativeSdkExample/Pods-ReactNativeSdkExample-resources.sh\"\n";

    			showEnvVarsInLog = 0;

    		};

    		F706883CA13F4E50A06B85B2 /* [CP] Check Pods Manifest.lock */ = {

    			isa = PBXShellScriptBuildPhase;

    			buildActionMask = 2147483647;

    			files = (

    			);

    			inputFileListPaths = (

    			);

    			inputPaths = (

    				"${PODS_PODFILE_DIR_PATH}/Podfile.lock",

    				"${PODS_ROOT}/Manifest.lock",

    			);

    			name = "[CP] Check Pods Manifest.lock";

    			outputFileListPaths = (

    			);

    			outputPaths = (

    				"$(DERIVED_FILE_DIR)/Pods-ReactNativeSdkExample-checkManifestLockResult.txt",

    			);

    			runOnlyForDeploymentPostprocessing = 0;

    			shellPath = /bin/sh;

    			shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n    # print error to STDERR\n    echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n    exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";

    			showEnvVarsInLog = 0;

    		};

    /* End PBXShellScriptBuildPhase section */

    /* Begin PBXSourcesBuildPhase section */

    @@ -406,7 +406,7 @@
  
    		};

    		13B07F941A680F5B00A75B9A /* Debug */ = {

    			isa = XCBuildConfiguration;

    			baseConfigurationReference = EDCEA27594161CE66029771A /* Pods-ReactNativeSdkExample.debug.xcconfig */;

    			baseConfigurationReference = 627A5082522E8122626A42E9 /* Pods-ReactNativeSdkExample.debug.xcconfig */;

    			buildSettings = {

    				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;

    				CLANG_ENABLE_MODULES = YES;

    @@ -436,7 +436,7 @@
  
    		};

    		13B07F951A680F5B00A75B9A /* Release */ = {

    			isa = XCBuildConfiguration;

    			baseConfigurationReference = 24F802EFDCFB094D34916C72 /* Pods-ReactNativeSdkExample.release.xcconfig */;

    			baseConfigurationReference = C37A515B34C484F156F48110 /* Pods-ReactNativeSdkExample.release.xcconfig */;

    			buildSettings = {

    				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;

    				CLANG_ENABLE_MODULES = YES;

ios/RNIterableAPI/RNIterableAPI.h

-Original file line number
+Diff line change
@@ -1,8 +1,18 @@
-    //
-    //  RNIterableAPI.h
-    //  RNIterableAPI
-    //
-    //  Created by Loren Posen on 6/11/25.
-    //  Copyright © 2025 Iterable. All rights reserved.
-    //
-    #import <React/RCTBridgeModule.h>
+    #import <Foundation/Foundation.h>
+    #import <React/RCTEventEmitter.h>
+    #if RCT_NEW_ARCH_ENABLED
+      #import <React/RCTUtils.h>
+      #import <React/RCTConvert.h>
+      #import <React/RCTTurboModuleRegistry.h>
+      #import <RNIterableAPISpec/RNIterableAPISpec.h>
+    @interface RNIterableAPI : RCTEventEmitter <NativeRNIterableAPISpec>
+    #else
+      #import <React/RCTBridgeModule.h>
+    @interface RNIterableAPI : RCTEventEmitter <RCTBridgeModule>
+    #endif
+    @end

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MOB-11827] add-new-architecture-support #687

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!