refactor: update templateId parameter type to nullable in trackPushOpenWithCampaignId

Author: lposen

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

@@ -187,8 +187,8 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
         IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
     }
 
-    public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, (int) templateId, messageId, optSerializedDataFields(dataFields));
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {
+        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? (int) templateId : null, messageId, optSerializedDataFields(dataFields));
     }
 
     public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
   }
 
   @Override
-  public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {
     moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
   }
 

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
     }
 
     @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {
       moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
     }
 

ios/RNIterableAPI/RNIterableAPI.mm

@@ -155,7 +155,7 @@ - (void)trackEvent:(NSString *)name dataFields:(NSDictionary *)dataFields {
 }
 
 - (void)trackPushOpenWithCampaignId:(double)campaignId
-                         templateId:(double)templateId
+                         templateId:(NSNumber *)templateId
                           messageId:(NSString *)messageId
                   appAlreadyRunning:(BOOL)appAlreadyRunning
                          dataFields:(NSDictionary *)dataFields {
@@ -382,8 +382,8 @@ - (void)passAlongAuthToken:(NSString *_Nullable)authToken {
 }
 
 RCT_EXPORT_METHOD(
-    trackPushOpenWithCampaignId : (double)campaignId templateId : (double)
-        templateId messageId : (double)messageId appAlreadyRunning : (BOOL)
+    trackPushOpenWithCampaignId : (double)campaignId templateId : (NSNumber *)
+        templateId messageId : (NSString *)messageId appAlreadyRunning : (BOOL)
             appAlreadyRunning dataFields : (NSDictionary *)dataFields) {
   [_swiftAPI trackPushOpenWithCampaignId:campaignId
                               templateId:templateId

ios/RNIterableAPI/ReactIterableAPI.swift

@@ -170,7 +170,7 @@ import React
   @objc(trackPushOpenWithCampaignId:templateId:messageId:appAlreadyRunning:dataFields:)
   public func trackPushOpenWithCampaignId(
     campaignId: Double,
-    templateId: Double,
+    templateId: NSNumber?,
     messageId: String,
     appAlreadyRunning: Bool,
     dataFields: NSDictionary?
@@ -180,7 +180,7 @@ import React
 
     IterableAPI.track(
       pushOpen: campaignId as NSNumber,
-      templateId: templateId as NSNumber,
+      templateId: templateId,
       messageId: messageId,
       appAlreadyRunning: appAlreadyRunning,
       dataFields: swiftDict)

src/api/NativeRNIterableAPI.ts

@@ -39,7 +39,7 @@ export interface Spec extends TurboModule {
   ): void;
   trackPushOpenWithCampaignId(
     campaignId: number,
-    templateId: number,
+    templateId: number | null,
     messageId: string,
     appAlreadyRunning: boolean,
     dataFields?: { [key: string]: string | number | boolean }