lotus: lower threshold for Apple 96W and TS4 98W chargers#44
Open
Terrails wants to merge 2 commits intoFrameworkComputer:fwk-lotus-azalea-19573from
Open
lotus: lower threshold for Apple 96W and TS4 98W chargers#44Terrails wants to merge 2 commits intoFrameworkComputer:fwk-lotus-azalea-19573from
Terrails wants to merge 2 commits intoFrameworkComputer:fwk-lotus-azalea-19573from
Conversation
Terrails
force-pushed
the
lotus-lower-threshold
branch
from
873709e to
5f480c6
Compare
Terrails
force-pushed
the
lotus-lower-threshold
branch
2 times, most recently
from
9662a77 to
df9aa14
Compare
Terrails
force-pushed
the
lotus-lower-threshold
branch
from
df9aa14 to
b6ea31f
Compare
|
@kiram9 Could you please take a look at this? |
Member
|
Ryzen 7040 16in power tables have been redone in 4.xx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lowers the required AC charger power to get the higher SoC power limits on chargers that are almost 100W.
I and most likely a decent chunk of Framework 16 users use a Caldigit TS4 dock which unfortunately does not provide the full 100W required to get the higher power limits, but instead exposes itself as a 20V 4.9A charger (98W) as can be seen from the output of
ectool console:I have initially wanted to drop this limit down to 98W, but there are other chargers like the Apple 96W USB-C charger and it would also benefit the users of those to drop this threshold down to 96W so that performance is not limited while plugged into these near 100W chargers.
I have already tested this change on my non-dGPU FW16 and it has been working flawlessly.
For anyone else wanting to try this out, the firmware files are built using workflows on my fork. A flashing guide can be found on this gist.