-
Notifications
You must be signed in to change notification settings - Fork 468
feat: Expose "Enable real-time flags" option when self-hosting, add docs #4836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
80a0c78 to
6cf079c
Compare
Docker builds report
|
| <!-- | ||
| The SSE service exposes the following Prometheus metrics at the `/metrics` endpoint: | ||
|
|
||
| - `flagsmith_sse_subscribers_active`: number of active subscribers | ||
| - `flagsmith_sse_subscribers_total`: total number of subscribers | ||
| - `flagsmith_sse_redis_commands_total`, with labels `command=SCAN|PING|SET` | ||
| - `flagsmith_sse_redis_errors_total`, with labels `command=SCAN|PING|SET` | ||
| --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should probably delete this
- I'd like to see an issue for implementing these, if we don't have it yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an old PR here, which I never got the tests working for: https://github.com/Flagsmith/flagsmith-sse/pull/32
Currently, the "Enable real-time flags" project setting is hardcoded to be only visible in SaaS. This PR makes it so that it's always visible, and adds documentation for self-hosting the SSE service.